[FSTORE-1672][4.1] Allow multiple on-demand features to be returned from an on-demand transformation function and allow passing of local variables to a transformation function #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on-demand transformation function and allow passing of local variables to a transformation function (logicalclocks#452) * working code for many to many transformation and also transformation context * adding comments and tests * update feature group schema based on transformation function only if transform is set to true * throw exception if transformation context is passed to training datatset materialization jobs from the python engiine * adapting check_missing_request_parameters to handle multiple on-demand feature returned from a single transformaiton function * checking excplicitly that the passed feature vector is None so that pandas dataframe can also be passed to get feature vector * adding else to handle usecase in which features have to be overwritten after tranformations * adding null check for entries before trying to add them to request parameters * addressing review comments --------- Co-authored-by: Ralf <bubriks@gmail.com>
SirOibaf
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-pick changes not in #452 to the 4.1 branch
JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1672
Priority for Review: -
Related PRs:
https://github.com/logicalclocks/hopsworks-ee/pull/2223
https://github.com/logicalclocks/loadtest/pull/514
logicalclocks/logicalclocks.github.io#440
How Has This Been Tested?
Checklist For The Assigned Reviewer: